search

allfro / canari

Local and Remote Maltego Rapid Transform Development Framework
http://www.canariproject.com
102 stars 27 forks source link

Minor bug fixes of original code. #34

Closed reenberg closed 10 years ago

reenberg commented 10 years ago

The super call in init of the MaltegoException class was given the Super class and not the sub class.

The appendelement and removeelement of the _Entity class was trying to add and remove elements from the underlying fields and labels variables as if they were lists. However they were actually dictionaries.

reenberg commented 10 years ago

I tested the append- and removeelement parts of the _Entity, however I could not come up with a real use case where these two functions would actually be called by any code, which might also suggest why this bug was newer triggered. Based on this, is the code strictly necessary?

allfro commented 10 years ago

Hi @reenberg

Thanks for your submissions and hard work! I just got back from Brazil and I'm still catching up to things. I will be looking at your pull requests in the next coming days.

Cheers,

Nadeem

reenberg commented 10 years ago

I finally got around structuring my additions and committing them during some of the boring talks at RECON. More to come..

I still ow you an email, and it is on the way.. Hopefully I will get it wrapped up one of the following days.. On 30 Jun 2014 11:53, "allfro" notifications@github.com wrote:

Hi @reenberg https://github.com/reenberg

Thanks for your submissions and hard work! I just got back from Brazil and I'm still catching up to things. I will be looking at your pull requests in the next coming days.

Cheers,

Nadeem

— Reply to this email directly or view it on GitHub https://github.com/allfro/canari/pull/34#issuecomment-47549265.