Camera not using full screen

allgood / OpenNoteScanner

Android application for scanning and manipulating handwritten notes and documents.

Other

1.37k stars 285 forks source link

Camera not using full screen #174

Closed tobru closed 5 years ago

tobru commented 5 years ago

On my Android 9 phone somehow not the whole screen is used for the camera:

Screenshot_20190810-193413_Open_Note_Scanner

Android Version: LineageOS for microG 16.0
Device: LeEco Max2 (x2)

Steps to reproduce

Just open the app, that's the default screen.

Expected behaviour

Camera view uses whole screen.

Actual behaviour

Not the whole screen is used.

Would you like to work on the issue?

Testing possible fixes

allgood commented 5 years ago

This happens because the highest resolution available have an aspect ratio different from the screen. It happens on many devices, but looks like yours have a perfect square aspect ratio.

This is not a bug, but it is a behavior that may be solved when I implement specific resolution selection on the options.