search

allgood / OpenNoteScanner

Android application for scanning and manipulating handwritten notes and documents.
Other
1.32k stars 278 forks source link

OpenCV Manager is not embedded #239

Closed giupardeb closed 3 years ago

giupardeb commented 3 years ago

Hi guys, I already installed OpenNoteScanner from fdroid. Once opened it, the app show me a downloading dialog for downloading OpenCV Manager. This Dialog stays open without doing anything. I was forced to download opencv manager manually from this link.

The question is: is OpenCV Manager embedded?

EDIT: I think there is a error in this code https://github.com/ctodobom/OpenNoteScanner/blob/9c0ce1a24c581ccb35fad026c90537d356ba5a65/app/src/main/java/com/todobom/opennotescanner/helpers/CustomOpenCVLoader.kt#L92

allgood commented 3 years ago

Hi @giupardeb ,

f-droid release haven't OpenCV embedded because f-droid doesn't support spitted builds, making the final apk file huge in consequence of having binaries from all architectures.

You can download the apk built by myself on the releases section here on github, just need to select the correct arch.

On my tests the download of the opencv is working, but some devices are more trickier on this part. Anyway, there are work in progress to make opencv always embedded, even on f-droid.

giupardeb commented 3 years ago

Hi @ctodobom thank you for your explanation