search

allgood / OpenNoteScanner

Android application for scanning and manipulating handwritten notes and documents.
Other
1.32k stars 278 forks source link

Does Nothing #249

Open ourichermath opened 3 years ago

ourichermath commented 3 years ago

I've installed the app-fdroid-arm64-v8a-release.apk version onto my Pixel XL running LineageOS 17.1 (Android 10 dated 20 Jan 2021 without GAPPS). According to https://www.devicespecifications.com/en/model/a95e3ed6 , the Pixel XL is 64 bit and uses the ARMv8-A instruction set, so that appears to be the correct apk. After I installed the app, I start it up. It starts with the camera on, I highlight a document and hit the button to scan it. Shortly thereafter, the app just shuts down. Re-opening it and tapping the "document" icon below the three dots takes me to a blank page. I'm assuming any scanned documents are supposed to be there, but it's empty.

Steps to reproduce

  1. Open app
  2. Fit document in scan window
  3. Tap button to scan document

Expected behaviour

There should be some action that indicates the document was scanned and tapping the "document" icon should open the scanned document location to show all scanned documents.

Actual behaviour

A few seconds after hitting the button to scan the document, the app quits and nothing is stored in the scanned document location.

Would you like to work on the issue?

No. Sorry. I'm clueless.

geofferb commented 3 years ago

Have you tried giving the app file permissions?

EauBureau commented 3 years ago

Same thing happens for me. Android 10 and version 1.0.35-fdroid app-fdroid-arm64-v8a-release.apk (My phone is ARM 64 too)

Have you tried giving the app file permissions?

Yes it has all the permissions it requires (Camera and Storage, and "no permissions denied")

allgood commented 3 years ago

Can you please provide a logcat output of the error? Maybe the log can tell what is happening!

Em ter., 20 de abr. de 2021 às 12:11, EauBureau @.***> escreveu:

Same thing happens for me. Android 10 and version 1.0.35-fdroid app-fdroid-arm64-v8a-release.apk (My phone is ARM 64 too)

Have you tried giving the app file permissions?

Yes it has all the permissions it requires (Camera and Storage, and "no permissions denied")

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/allgood/OpenNoteScanner/issues/249#issuecomment-823354600, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOKDUHVVBG37FKVNSY6Q4DTJWKTVANCNFSM4WSCBC7A .

EauBureau commented 3 years ago

I'm not a developer, but after playing around with adb I think this is what you want.

(I also tried the armeabi-v7a version on my ARM64 phone and it installed and launched but has the same issue as the ARM64 version.)

allgood commented 3 years ago

This is very strange because the error says it is a null pointer exception and the code for 1.0.35-fdroid have an explicit check for null before issuing the method.

                    if (AnimationRunnable.this.bitmap != null) {
                        AnimationRunnable.this.bitmap.recycle();
                    }

this check wasn't present on previous versions. are you sure you are running 1.0.35-fdroid? Are you downloading the apk from the releases page of the project or are you using f-droid?

EauBureau commented 3 years ago

I am using your version from github. I downloaded it from this URL https://github.com/allgood/OpenNoteScanner/releases/download/1.0.35-fdroid/app-fdroid-arm64-v8a-release.apk (Its sha256 should be 94d18a0169988a6e004aa2455fbb97b5311229c58db1d5d54ca94bb4775bb866 )

Here is a bit more logcat. Its from lauching the app until it crashes after taking a photo.

allgood commented 3 years ago

Reading the logcat I can tell that ONS was unable to save the image file. As you told all permissions are given I think some protection specific of LineageOS is taking action, unfortunately I can't test with lineageOs on the devices I own.

I would appreciate if somebody reading this can do a deeper look using lineage.

EauBureau commented 3 years ago

I am using Android 10.

allgood commented 3 years ago

wow... read the OP message and thought it was lineage... will try to test the apk directly on my phone and get back here. I'm just unable to do it today.

EauBureau commented 3 years ago

No problem. There is no time pressure. Thanks for developing the app (and replying to this bug) :smiley:

allgood commented 3 years ago

I've just found the problem... binaries on release page was built on another commit that doesn't have the check I pasted above!

I will try to fix this on a next release.

EauBureau commented 3 years ago

I've just found the problem

Good job. That was quick!

I will try to fix this on a next release.

I'm looking forward to it. Thanks again.