search

alliance-genome / agr_file_generator

This repo is for generating files from Alliance resources
MIT License
1 stars 3 forks source link

AGR-2528 file-generator dockerhub => ECR code-changes #117

Closed mluypaert closed 3 years ago

mluypaert commented 3 years ago

Makefile, Dockerfile and docker-compose updates done to move away from dockerhub and into ECR as our docker image registry (analogous to alliance-genome/agr_ansible_devops#15)

mluypaert commented 3 years ago

@oblodgett I noticed one of the above checks failed, and after looking into it, I think there's more work to be done in GoCD. It fails authentication on a docker image pull from ECR, which I assume means there will need to be more GoCD pipelines updated to pull images in as materials (analogous to the changes you already did in GoCD for AGR-2528), so the plugin we installed can handle the ECR authentication.

oblodgett commented 3 years ago

@mluypaert yes... not all the PR pipelines have been moved over... will get to those today, thanks.