search

alliance-pcsg / primo-explore-custom-actions

:hammer_and_wrench: easily add custom actions to primo-explore's actions menu.
MIT License
15 stars 7 forks source link

orbis-cascade Namespace #18

Open elizoller opened 5 years ago

elizoller commented 5 years ago

When I add this using '@orbis-cascade/primo-explore-custom-actions', i then have to import using @orbis-cascade namespace as well or else it can't find the node package. When I use the namespace for import, it then can't find the module customActions. Does it sound like I'm doing something wildly wrong? Worth noting I'm using --browserify

uleodolter commented 5 years ago

hi @elizoller, i have created a pull request which solves the problem for me.

elizoller commented 5 years ago

Even with this PR, i still needed to use import '@orbis-cascade/primo-explore-custom-actions'; with the --browserify flag This doesn't really seem like a technical issue, more of a documentation one.

uleodolter commented 5 years ago

you are right, my PR is not related to browserify, but it makes the module working again for me. without my patch i see an angular exception and customActions module is not available.

elizoller commented 5 years ago

ah, ok. glad it works for you!