alliander-opensource / weather-provider-api

This API is intended to help you fetch weather data from different data sources in an efficient and uniform way. By just supplying a list of locations and a time window you can get data for a specific source immediately. This project is licensed under the MPL-2.0 license.
https://alliander-opensource.github.io/weather-provider-api/
Mozilla Public License 2.0
27 stars 6 forks source link

84 wpla 2x bug precipitation always zero with knmi uurgegevens #86

Closed rflinnenbank closed 1 year ago

rflinnenbank commented 1 year ago

Fix for issue #84

The number of stored decimals for float values has been doubled from 2 to 4. This fixes a bug where the field "Uurgegevens" would always end up as 0 for text based files, due to the default harmonization level being in m/h rather than mm/h. Due to API consistency this choice of unit will remain the same for version 2.x of the API calls.

It is not done to change the output of an API without proper warning in advance, which is why we change the unit depth, rather than the unit itself...

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication