feat: Add property to hide min & max values in "Slider" component

allianz / ng-aquila

Angular UI Component library for the Open Insurance Platform

https://allianz.github.io/ng-aquila/

Other

205 stars 32 forks source link

feat: Add property to hide min & max values in "Slider" component #21

Closed elharony closed 3 years ago

elharony commented 3 years ago

Add property to hide min & max values in "Slider" component

🎯 Goals

Currently, there's no built-in property to show/hide min & max values in "Slider" component. Those parts:

ng-aquila-add-property-to-showhide-minmax-values

📖 References

Slider Component API

👌 Requirements

Adding a new built-in property to make it easier to show/hide the min and max values.

Phil147 commented 3 years ago

Hi @elharony

thanks for your request. That feature makes sense for certain use cases. I've seen you already implemented it. In case you are working for Allianz you could open a PR with your solution to the internal repository. If not we don't have a CLA for external contributions set up yet but then we would implement it ourselves.

yd-allianz commented 3 years ago

Hi @elharony

thanks a lot for your contribution! Unfortunately, as we don't have a CLA for external contributions, we couldn't merge your PR directly. Instead, we implemented the feature requested by you ourselves. It will be available with the next release.