search

allianz / ng-aquila

Angular UI Component library for the Open Insurance Platform
https://allianz.github.io/ng-aquila/
Other
209 stars 36 forks source link

[nx-selectable-card] Error message is still shown after selectable card has been validated #23

Closed az-eduard-rusanovschi closed 3 years ago

az-eduard-rusanovschi commented 3 years ago

In the selectable card with the custom function validation the error message (nx-error) is still shown. However the red border around the control disappears. The validation function uses another component variable to check error state. Error message shoud disappear as soon as the control is valid again, which is not the case at the moment. This is a bug.

⚡ Reproduction

StackBlitz link to reproduce the issue: https://stackblitz.com/edit/angular-yopodq

Steps to reproduce:

  1. Click on the "change state" button in the StackBlitz link above.

📗 Expected Behavior

Both red border of the control and the nx-erro error message "This card is incomplete." should disappear.

📕 Actual Behavior

Only control red border disappear. Error message is still shown.

📦 Environment

As in the StackBlitz link above.

f-masche commented 3 years ago

Thanks for the bug report. This seems to be a change detection issue, we will look into this.

yd-allianz commented 3 years ago

Hi @az-eduard-rusanovschi thank you again for reporting the problem, sorry it took longer than expected for us to start fixing it. The issue is now fixed and will be deployed with the next release.