fix(comparison-table): teardown the subscription and do not run change detection on DOM timer

arturovt commented 2 years ago

Definition of Done

Mandatory for all PRs

[x] All unit and build tests are green 🚦
[ ] Reviewed and approved by maintainer :+1:

Applicable to some PRs

[ ] W3C AA accessibility fulfilled
[ ] Documentation and examples are updated
[ ] Tested on all supported browsers (see Getting Started)
[ ] Unit tests with good coverage (e.g., >80%)
[ ] No unintended visual changes. If needed, run the visual regression testing (see README.md)

In case there is any line item that you don't fullfil please add an explanation why.

Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Why should this be in the library?

yd-allianz commented 2 years ago

Hi @arturovt thanks for contributing. Due to Allianz policies, we can't accept direct code merges from open source. If you have access to the internal repository, please open your PR in there.

Otherwise, we are going to recreate your solution in our internal repository, go through necessary stages and then release it to public. In that case we will let you know as soon as this feature is released.

yd-allianz commented 2 years ago

Hi @arturovt we have implemented your change internally and released it. Thanks again for contributing.

allianz / ng-aquila