allianz / ng-aquila

Angular UI Component library for the Open Insurance Platform
https://allianz.github.io/ng-aquila/
Other
213 stars 38 forks source link

[nx-dropdown] An error appears when selecting any values in the drop down list #73

Open keeratita opened 6 days ago

keeratita commented 6 days ago

⚡ Reproduction

Steps to reproduce:

  1. Go to a website : https://allianz.github.io/ng-aquila/welcome
  2. Try to select any values in a dropdown on Try it out section
  3. Got an error "Maximum call stack"

📗 Expected Behavior

Should select the value in the dropdown list and show it/them properly.

📕 Actual Behavior

error

📦 Environment

keeratita commented 6 days ago

Should it have to use value attribute instead of nxValue in the <nx-dropdown-item>?

Source: src/app/starter-app.html

It seems the demo is working fine when changing these lines from

          <nx-dropdown-item nxValue="1">1</nx-dropdown-item>
          <nx-dropdown-item nxValue="2">2</nx-dropdown-item>
          <nx-dropdown-item nxValue="3">3</nx-dropdown-item>

to

          <nx-dropdown-item value="1">1</nx-dropdown-item>
          <nx-dropdown-item value="2">2</nx-dropdown-item>
          <nx-dropdown-item value="3">3</nx-dropdown-item>
Phil147 commented 5 days ago

Hi @keeratita

Should it have to use value attribute instead of nxValue in the <nx-dropdown-item>?

Yes correct in v16 we removed the nx prefix in inputs for components. The starter app on the main page should get updated also to use the latest version.