Debug feature: Performance Monitor Issue

[UnrealKaraulov]

https://github.com/alliedmodders/amxmodx/commit/8ee3da24cb811ca5c425bc4aec954eee22ca371d

If someone get problems with using this feature or have any suggestions, please use this issue for it.

[UnrealKaraulov]

Closed

[UnrealKaraulov]

@dvander I see on older linux os next message:

L 12/06/2021 - 08:33:46: [META] ERROR: dll: Failed query plugin '<amxmodx_mm_i386.so>'; Couldn't open file '/home/server/game/cstrike/addons/amxmodx/dlls/amxmodx_mm_i386.so': /home/server/game/cstrike/addons/amxmodx/dlls/amxmodx_mm_i386.so: undefined symbol: _ZNSt6chrono3_V212steady_clock3nowEv

Possible need add something to buildbot ?

[dvander]

It's missing linkage to libstdc++.

We find the static library here: https://cs.alliedmods.net/amxmodx/source/AMBuildScript#316 And currently only amxxpc uses it here: https://cs.alliedmods.net/amxmodx/source/compiler/amxxpc/AMBuilder#14

amxmodx_i486.so needs a similar link step, I think.

[UnrealKaraulov]

@dvander I do build manual from https://wiki.alliedmods.net/Building_AMX_Mod_X

But get next errors:

[UnrealKaraulov]

All is need rename to == ?

[dvander]

Yeah, newer versions of Python will complain about this. It's a bug in the script, we should have used "==" for string comparison.

[UnrealKaraulov]

@dvander i tried to add std support in https://github.com/alliedmodders/amxmodx/pull/1026 and think now it works.

[dvander]

I merged the build fix. I think it should work. You can test by using "ldd -d -r <.so file>" on the command-line, and it should tell you if any symbols are missing.

[UnrealKaraulov]

I merged the build fix. I think it should work. You can test by using "ldd -d -r <.so file>" on the command-line, and it should tell you if any symbols are missing.

It can be added to GitHub actions?

[rtxa]

Hi @UnrealKaraulov. Would you mind to explain how this new feature works? I'm using one of the latest commits and I couldn't fail to notice that some of the plugins that I have in debug mode are throwing messages like [agmodx.amxx] performance issue. Function plugin_init executed more than 100.6ms.. Can this be disabled without disabling the debug feature in plugins which is useful for other kind of errors?

[UnrealKaraulov]

@rtxa now it impossible, see https://github.com/alliedmodders/amxmodx/pull/1027 and https://github.com/alliedmodders/amxmodx/pull/1028

[UnrealKaraulov]

@rtxa https://github.com/alliedmodders/amxmodx/pull/1028 is fix for this pull request, for "disable/enable for all plugins", and other fixes. But stil not merged :(