alliedmodders / amxmodx

AMX Mod X - Half-Life 1 Scripting and Administration
http://www.amxmodx.org/
489 stars 197 forks source link

amx_debug '2' ignore missing debug #1027

Closed UnrealKaraulov closed 1 year ago

UnrealKaraulov commented 2 years ago

Please, if no debug info, don't crash plugins, just write error and skip debug info.

Description:

Many plugins like extended ban systems (fresh bans, etc) or antihacks (aim detectors, etc) compiled without debug for protect source code from hackers. At this moment, if activate amx_debug 2 all plugins without debug info stop working.

After the merge, we will just write information about the missing of debug option and the plugin continues work without any issues. (Also it can be useful for debug this plugins with Performance Monitor even without debug info)

dvander commented 2 years ago

I'm confused, what crash is this fixing?

UnrealKaraulov commented 2 years ago

@dvander

Before this fix. If we enabled amx_debug 2, all plugins compiled without debug option - stopped with error. After this fix. If we enabled amx_debug 2, all plugins compiled without debug option - continue works, but without debug flag.

I hope now I wrote it easier and clearer :)

UnrealKaraulov commented 2 years ago

@dvander i think latest commit in this PR is really latest.

Now if user forced set debug in plugins.ini - default behavior. If user set amx_debug 2, then skip debug if no debug info found.

Do You think this is more better or was the previous version is better?

UnrealKaraulov commented 2 years ago

Any questions?

wopox1337 commented 1 year ago

@dvander @Arkshine ping

UnrealKaraulov commented 1 year ago

@dvander @Arkshine америкосы