search

alliedmodders / amxmodx

AMX Mod X - Half-Life 1 Scripting and Administration
http://www.amxmodx.org/
494 stars 197 forks source link

plmenu.sma: team menu issues #633

Open Freeman-AM opened 5 years ago

Freeman-AM commented 5 years ago

This part of the plugin had several improvements without that much checks and need a rewrite.

Firstable: teams are not handled the same way in HL and CS 1.6. That means it should be better to have a specific plmenu.sma for CS 1.6 like we did for some other plugins. But that also means a decent teammenu is inexistant for HL and need either to be coded or removed from the main amxmodmenu or available commands.

Secondable: silent transfer option (CS 1.6 case) This was merged too quickly in the plugin. We can create a spectator bug : https://github.com/alliedmodders/amxmodx/pull/175 We can silent transfer the bomb to the ct team. Not tested but I'm sure we can silent transfer the VIP.

I'm sure this option is used so IMO, we should not remove it but rather prevent all cases.

Freeman-AM commented 5 years ago

I encountered many similar issues when i wrote CS AFK Manager : https://forums.alliedmods.net/showthread.php?t=256449 You can get some ideas to save time about how i handled this.

I tried to creates a team menu for HL a long time ago. I gave up for reasons i don't remember. https://github.com/alliedmodders/amxmodx/pull/245

Arkshine commented 5 years ago

Silent Transfer is useless for most of the people. Not sure why it has been merged.

We should have a real way to transfer alive the player. In CS, there is definitively some function to look at, such as SwitchTeam, unfortunately, it's not complete (bomb is not handled for example).

Looking at ReAPI, they added a native using SwtichTeam directly. They also added a native to set a team internally but it deals properly with the bomb/defuser/internal players count.