search

alliedmodders / amxmodx

AMX Mod X - Half-Life 1 Scripting and Administration
http://www.amxmodx.org/
499 stars 203 forks source link

Sql explaining #811

Closed afwn90cj93201nixr2e1re closed 4 years ago

afwn90cj93201nixr2e1re commented 4 years ago

https://github.com/alliedmodders/amxmodx/blob/0ccba6700665e9369f85bc56b0ccae4ff4415f19/modules/sqlite/threading.cpp#L418 Which called from: https://github.com/alliedmodders/amxmodx/blob/2559fcf00aecb19fb6e6f8de846ae37cbcd6d572/modules/sqlite/basic_sql.cpp#L427

So and SQL_FieldNumToName: https://github.com/alliedmodders/amxmodx/blob/2559fcf00aecb19fb6e6f8de846ae37cbcd6d572/modules/sqlite/basic_sql.cpp#L378 And SQL_IsNull and SQL_ReadMoreResult: https://github.com/alliedmodders/amxmodx/blob/2559fcf00aecb19fb6e6f8de846ae37cbcd6d572/modules/sqlite/basic_sql.cpp#L216

Why there is different ways?

I rly don't get why sometime you just casting to unsingned int but otherwise in SQL_FieldNameToNum which is like same as others you going to iterate each array instead just casting, what's wrong? Is that just typo? Or what?

dvander commented 4 years ago

Questions about the source are better asked on IRC or the forums, since this doesn't seem like a bug report or issue. There is a slightly higher cost to accessing fields by name, thus both methods are exposed.