artkirienko commented 4 years ago

Can't vote for map extending

!Nextmap Chooser default client slots

Help us help you

[x] I have checked that my issue doesn't exist yet.
[x] I have tried my absolute best to reduce the problem-space and have provided the absolute smallest test-case possible.
[x] I can always reproduce the issue with the provided description below.

Environment

Operating System version: Linux Debian 10.4 Buster

Game/AppID (with version if applicable): Half-Life/70

Protocol version 47/48
Exe version 1.1.2.2/Stdio (valve)
Exe build: 17:23:32 May 24 2018 (7882)

Current AMX Mod X version: 1.8.2
Current Metamod version: Metamod-p version 1.21p38
[x] I have updated AMX Mod X to the latest version and it still happens.
[ ] I have updated AMX Mod X to the latest snapshot and it still happens.
[ ] I have updated Metamod to the latest version and it still happens.

Description & steps to Reproduce

By default in the latest steam Half-Life client (build 8308), only 5 slots are defined, previous builds had same configs.

Screenshot 2020-06-02 at 22 50 11

By default AMX Mod X (version 1.8.2) Nextmap Chooser uses 7 slots, so a player can't vote for map extending. photo_2020-06-02 23 34 52

There is a fix for this problem:

#include <amxmodx> 

public plugin_init() { 
    register_plugin("Bind key","1.0","xPaw") 

} 

public client_connect(id) { 
  client_cmd(id, "bind 0 slot10")
  client_cmd(id, "bind 1 slot1")
  client_cmd(id, "bind 2 slot2")
  client_cmd(id, "bind 3 slot3")
  client_cmd(id, "bind 4 slot4")
  client_cmd(id, "bind 5 slot5")
  client_cmd(id, "bind 6 slot6")
  client_cmd(id, "bind 7 slot7")
  client_cmd(id, "bind 8 slot8")
  client_cmd(id, "bind 9 slot9")
}

but it should work fine by default!

OciXCrom commented 4 years ago

There is no AMXX related problem here, nor that is a valid fix. The plugin uses slowhacking which is not allowed and probably won't mork on most clients. Clients should obviously have those keys bound to the slots if they want to use the options in the menu.

A much more suitable place to report this "issue" would be in Valve's Half-Life Github page. There is nothing AMXX can do to overcome this problem.

artkirienko commented 4 years ago

@OciXCrom why does AMXX use 7 slots by default instead of 5 slots then? 🤔

pizzahut2 commented 4 years ago

Until this is fixed, you can edit the number of slots in the source code (mapchooser.sma) and recompile.

#define SELECTMAPS 3

Or maybe use a two-page menu. I'd rather have as many maps on one page as possible. Examples:

Using 4 maps:

menu page 1
1. map name
...
4. map name
5. next page

menu page 2
1. extend
2. none
3.
4.
5. previous page

Using 5 maps:

menu page 1
1. Select map
2. Extend current map
3. None

menu page 2
1. map name
...
5. map name

artkirienko commented 4 years ago

Created an issue for HL https://github.com/ValveSoftware/halflife/issues/2921

OciXCrom commented 4 years ago

@OciXCrom why does AMXX use 7 slots by default instead of 5 slots then? 🤔

Because there's no reason for such a limitation when the menus are already very limited. The amount of people who haven't bound these keys is inconsiderably small. You can easily tell them how to do it rather than making the menu have less options.

WPMGPRoSToTeMa commented 4 years ago

Because there's no reason for such a limitation when the menus are already very limited.

That can be optionally reduced for HL specifically, but it would be a breaking change though.

SmileYzn commented 4 years ago

if you want to fix in amxx why not check buttons pressed and send an client command?

like client_cmd(id,"slot9");

??

OciXCrom commented 4 years ago

@SmileYzn - you can't check for buttons pressed.

alliedmodders / amxmodx