search

alliedmodders / amxmodx

AMX Mod X - Half-Life 1 Scripting and Administration
http://www.amxmodx.org/
499 stars 203 forks source link

Bots creating inconsintency #948

Open afwn90cj93201nixr2e1re opened 3 years ago

afwn90cj93201nixr2e1re commented 3 years ago

Let's start with the fact that at the moment we can not intercept (probably?) outgoing calls using dllfunc.

dllfunc(DLLFunc_ClientConnect, id, "Test", "127.0.0.1", szMessage); dllfunc(DLLFunc_ClientPutInServer, id);

etc. That means that we will never receive any kind of ClientConnects or ClientPutinServers on some bot clients.

afwn90cj93201nixr2e1re commented 3 years ago

Some of them not even coded in correct way: https://github.com/Bots-United/joebot/blob/master/dlls/bot.cpp#L312

Why is different index used there: https://github.com/Bots-United/joebot/blob/master/dlls/bot.cpp#L351-L353

Why there's no SET_CLIENT_KEY_VALUE(ENTINDEX(pEdict), GET_INFOBUFFER(pEdict), "*bot", "1"); calls after putinserver (i understand that there is no reason to put it in incompatible games)?

https://github.com/Bots-United/marine_bot/blob/master/bot.cpp#L619 same https://github.com/Bots-United/jk_botti/blob/master/bot.cpp#L862 same https://github.com/Bots-United/whichbot/blob/master/bot/src/cpp/worldstate/WorldStateUtil.cpp#L123 same https://github.com/Bots-United/joebotxp/blob/master/dlls/GameHL.cpp#L216 same https://github.com/Bots-United/joebotxp/blob/master/dlls/GameDOD.cpp#L106 same https://github.com/Bots-United/racc/blob/836568ef7eecde208632571065c69f4b5f1a8d2b/release/common/util.cpp#L92 same https://github.com/Bots-United/ricobot/blob/master/bot.cpp#L243 same https://github.com/Bots-United/hlsdk10-bots/blob/master/PODBot/bot.cpp#L530 same https://github.com/Bots-United/hlsdk10-bots/blob/master/csbot/bot.cpp#L460 same https://github.com/Bots-United/hlsdk10-bots/blob/master/HPB_bot/bot.cpp#L198 same https://github.com/Bots-United/parabot/blob/master/bot/bot.cpp#L211 same https://github.com/Bots-United/HPB-bot/blob/master/bot.cpp#L623 same https://github.com/Bots-United/foxbot/blob/master/bot.cpp#L864 and https://github.com/Bots-United/foxbot/blob/master/bot.cpp#L850 same https://github.com/Bots-United/grave_bot/blob/master/dlls/bot.cpp#L743 same https://github.com/Bots-United/Parabot-1/blob/master/bot/bot.cpp#L189 same https://github.com/Bots-United/gina/blob/05d852b782d6a3a3a3ff70427396aca870e84c75/server.cpp#L290 same https://github.com/Bots-United/yapb1/blob/master/src/bot.cpp#L215 same https://github.com/yapb/yapb/blob/f870e7db4a9ebdacf2deb73d32a715551321ae35/src/manager.cpp#L941 - finally someone did it

APGRoboCop commented 3 years ago

https://github.com/APGRoboCop/foxbot/blob/master/bot.cpp#L822 is there but I cannot seem to find the ClientPutInServer(BotEnt);

APGRoboCop commented 3 years ago

Anything you like to add to the bots as well as checked my Github on the bots that I've recently enhanced?

APGRoboCop commented 3 years ago

Where should this *bot fix or that added to FoxBot bot.cpp, exactly? I don't quite understand...

amsaal commented 3 years ago

so which version of amxmodx works ? i have issue when i have like 30/32 , 2 player names becomes bots and they get kicked after someone connetcs.