alliedmodders / amxmodx

AMX Mod X - Half-Life 1 Scripting and Administration
http://www.amxmodx.org/
496 stars 200 forks source link

set_dhudmessage() hardcoded additional params #989

Open ShadowsAdi opened 3 years ago

ShadowsAdi commented 3 years ago

Hello, I found that alpha and effect colors are hardcoded even in dhudmessage: https://github.com/alliedmodders/amxmodx/blob/master/amxmodx/amxmodx.cpp#L639-L643 It would be great to have access to it like in the new set_hudmessage()

francoromaniello commented 3 years ago

You can easily use set_hudmesage and show_dhumessage after, set_dhud/set_hud are basically the same.

https://github.com/alliedmodders/amxmodx/blob/1.9-dev/amxmodx/amxmodx.cpp#L528-L562 https://github.com/alliedmodders/amxmodx/blob/1.9-dev/amxmodx/amxmodx.cpp#L636-L656

btw what is the reason for set_dhudmessage if it is the same as set_hudmessage ? not would be better to remove set_dhudmessage and use only one native ?

FEDERICOMB96 commented 3 years ago

DHud doesn't support this feature https://github.com/alliedmodders/amxmodx/blob/e17d37abe32c82314241a9e27140bee374746115/amxmodx/util.cpp#L240-L261