search

alliedmodders / hl2sdk

Half-Life 2 SDK Mirrors
https://github.com/valvesoftware
353 stars 173 forks source link

Update IGameEvent #155

Closed etojuice closed 1 year ago

etojuice commented 1 year ago

Credits: @komashchenko for his update on igameevents.h posted in AM discord. @hzqst GetPlayerSlot parameters

GAMMACASE commented 1 year ago

Was the generichash.cpp code copy & pasted from csgo leaked code?

etojuice commented 1 year ago

Was the generichash.cpp code copy & pasted from csgo leaked code?

this I can neither confirm nor deny

GAMMACASE commented 1 year ago

@psychonic well I'd need your approval on the code in the pr then

GAMMACASE commented 1 year ago

@psychonic so if all is okay, this could be merged in then.

psychonic commented 1 year ago

Yes, although it's still marked as a draft. Were there more changes planned in this MR?

etojuice commented 1 year ago

Yes, although it's still marked as a draft. Were there more changes planned in this MR?

I'm still working on this MR. I would request a review once I'm okay with the changes.

hzqst commented 1 year ago

GetPlayerSlot should be virtual CPlayerSlot GetPlayerSlot(const GameEventKeySymbol_t& keySymbol) = 0;

GAMMACASE commented 1 year ago

@etojuice I've updated the interface with my findings as well, now should be more complete, can you revisit it? And if all is okay I'll merge that in.

etojuice commented 1 year ago

@etojuice I've updated the interface with my findings as well, now should be more complete, can you revisit it? And if all is okay I'll merge that in.

lgtm. ty