search

alliedmodders / hl2sdk

Half-Life 2 SDK Mirrors
https://github.com/valvesoftware
341 stars 158 forks source link

Add voice listen methods to IVEngineServer2 #182

Closed Poggicek closed 7 months ago

GAMMACASE commented 7 months ago

Got any comment descriptions explaining what are these doing and what they are for?

psychonic commented 7 months ago

These appear to be ported from https://github.com/alliedmodders/hl2sdk/blob/csgo/public/ivoiceserver.h

I think at least copying over the same comment from there would be helpful.

psychonic commented 7 months ago

Also, those might be CPlayerSlot now

GAMMACASE commented 7 months ago

Ah, also removing the IVoiceServer would be nice as well if it's obsoleted?

psychonic commented 7 months ago

Ah, also removing the IVoiceServer would be nice as well if it's obsoleted?

Yes, good call. I agree.

Poggicek commented 7 months ago

yep will do after I attempt implementing a manager and see that everything works as expected

Poggicek commented 7 months ago

Should be all good now

GAMMACASE commented 7 months ago

@psychonic I assume this would require interfaces.lib rebuild?

psychonic commented 7 months ago

@psychonic I assume this would require interfaces.lib rebuild?

Nope. That one was never handled there. For reference, see interfaces/interfaces.cpp