search

alliedmodders / hl2sdk

Half-Life 2 SDK Mirrors
https://github.com/valvesoftware
341 stars 158 forks source link

[L4D2] (May 14th) `KeyValues` structure updated #239

Closed jensewe closed 1 month ago

jensewe commented 1 month ago

image-1

Similar to csgo's one: https://github.com/alliedmodders/hl2sdk/blob/c758235e71d85ae43acaadedd237b5e8966d60e9/public/tier1/KeyValues.h#L335-L361

but looks missing an int32 at the end (a1[10]).

jensewe commented 1 month ago

Any plan/progress on updating KeyValues codes? There're still crashes (KeyValues::RemoveEverything) on my end about KeyValues extensions.

463d54462061c512b5a09833c9fed70b7b2dce96 I believe this should be what the updated code looks like, but perhaps because of not recompiled SourceMod I'm still getting free() crashes when deleting KeyValues handles.

Glad if any further information could be provided.

Kenzzer commented 1 month ago

Given that this issue wasn't reported until now, no progress/update has been made. But feel free to open a PR !

Kenzzer commented 1 month ago

I've taken a look at your commit history on your fork, any reason you stopped using Valve's MemAlloc ?

jensewe commented 1 month ago

It's simply because the updated binary shows operator new/delete[] instead of malloc/free when using Valve's allocator, and I blindly decided to give it a try. Leave it out if it's just wrong.

jensewe commented 1 month ago

May I ask for a trigger build at least on SM 1.11? 🤔