bring back support for IServerPluginCallbacks v3 and v4

alliedmodders / metamod-source

Metamod:Source - C++ Plugin Environment and Detour Library for the Source Engine

http://www.metamodsource.net/

Other

386 stars 88 forks source link

bring back support for IServerPluginCallbacks v3 and v4 #104

Open markus-wa opened 1 year ago

markus-wa commented 1 year ago

Hi I saw we had to revert 4e5ddf833b7bb3af52f422f5a0bea91ba3b9e2d3 in 0e3586443210bb4e4012ff1fb992013dca911cc1 due to #101

Are there any plans to bring it back? This is a critical feature for us and we'd be happy to invest some time from our side to find a solution to avoid a fork, but would need some guidance on how to make this work (personally I don't have access to a Windows machine)

Could we conditionally enable them only for Linux or certain games?

asherkin commented 1 year ago

I'm unclear what this nets you, can't you hook the functions (at the dispatch point) regardless of if MM:S is opting in to the newer interface?

The path forward to un-reverting the change is primarily figuring out why it broke with the SDK2013 base engine, I don't know if that's been looked at yet.