search

alliedmodders / metamod-source

Metamod:Source - C++ Plugin Environment and Detour Library for the Source Engine
http://www.metamodsource.net/
Other
374 stars 83 forks source link

convert UTIL_TrimRight/TrimLeft to use std string internally #121

Closed sapphonie closed 10 months ago

sapphonie commented 11 months ago

See #118

Would convert these to take std::string& but they are surrounded by so much C code that it would be way too much of a pain. That's up next, though it really should be commented first for easier rewriting...

Well, eventually. I am bad at C.

This std string trimming code is from stack overflow, over @ https://stackoverflow.com/a/217605 - it's been referenced so many times and is so short that I don't really think there's any point in trying to rewrite the wheel.

I also don't want to use strcpy, but there's not a better way and it's not unsafe because the string is guaranteed to always be the same size or smaller.

Edit:

Also, this requires <algorithm>, so be aware

dvander commented 11 months ago

Need an #include <algorithm>?