search

alliedmodders / metamod-source

Metamod:Source - C++ Plugin Environment and Detour Library for the Source Engine
http://www.metamodsource.net/
Other
386 stars 88 forks source link

Make TF2 detection more strict #96

Closed Kenzzer closed 1 year ago

Kenzzer commented 2 years ago

This PR aims mostly at stopping metamod from recognising other games as "tf2" when they really shouldn't be. Like tf2classic that is a mod of sdk 2013.

@psychonic also suggested removing this check https://forums.alliedmods.net/showpost.php?p=2433735&postcount=11

psychonic commented 2 years ago

I believe that check was originally there for detecting tf_beta or no-code mods (similar to Counter-Strike: Classic Offensive for CS:GO) where a different gamedir but same binaries are used.

Unless there's another purpose for this change, I have mixed feeling of us making changes solely to aid in supporting specific types mods that Valve not only has an explicitly policy against the creation of, but that they actually took legal action against.

On Aug 23, 2022, at 5:48 PM, Benoist @.***> wrote:

 This PR aims mostly at stopping metamod from recognising other games as "tf2" when they really shouldn't be. Like tf2classic that is a mod of sdk 2013.

@psychonic also suggested removing this check https://forums.alliedmods.net/showpost.php?p=2433735&postcount=11

You can view, comment on, or merge this pull request online at:

https://github.com/alliedmodders/metamod-source/pull/96

Commit Summary

0d0d221 Restrict tf2 detection to just game dir name 2f99ed3 Merge branch 'master' into tf2_detection File Changes (1 file) M loader/loader.cpp (3) Patch Links:

https://github.com/alliedmodders/metamod-source/pull/96.patch https://github.com/alliedmodders/metamod-source/pull/96.diff — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

Kenzzer commented 2 years ago

My intention isn't to get metamod, and alliedmodders as a whole into legal hot waters. This change is mostly aimed at just confining tf2 detection to where it should be, and avoid troubles with sdk2013 mods. While yes this change will benefit that fan mod tf2classic, it isn't an explicit change that says we support tf2classic. In fact, metamod & sourcemod still very much don't, as heavy work lift is still required on their side to get everything working, it won't work out of the box.

On the topic of tf2 beta, I believe the game has been closed around 2013-2014. Supporting it still should no longer be a concern I believe.

Edit: Maybe we could leave that PR open, until the legal troubles has settled over there. I'm not hosting tf2 classic servers, nor do I intend to, but I still think it's right to correct an unintended behaviour of metamod. Although I very much understand why this PR might not land, and in which case the support of metamod will have to fall on the sdk2013 mod makers, by simply renaming that datatable.

Kenzzer commented 1 year ago

Discussion about this was sparked again in the discord. And I now believe this really doesn't need to be merged, if sdk2013 mods really wanted metamod & sourcemod support, they can simply change that one data table name, it really is a 2 lines change on their side, hardly more than what is needed here.