Server crash when a menu is closed early

[leoTiGRiS]

Help us help you

• [x] I have checked that my issue doesn't exist yet.
• [x] I have tried my absolute best to reduce the problem-space and have provided the absolute smallest test-case possible.
• [x] I can always reproduce the issue with the provided description below.

Environment

• Operating System version: Ubuntu 18.04
• Game/AppID (with version if applicable): 740 CS:GO
• Current SourceMod version: 1.9.0.6281
• Current SourceMod snapshot:
• Current Metamod: Source snapshot:
• [x] I have updated SourceMod to the latest version and it still happens.
• [x] I have updated SourceMod to the latest snapshot and it still happens.
• [x] I have updated SourceMM to the latest snapshot and it still happens.

Description

I'm running execute server, when 3+ players joining the server (I noticed that usually happens after that) server just crashes. Minidump analyze output: https://crash.limetech.org/4uanlblmlgru (fixed link)

[KyleSanderson]

You have a bad plugin freeing a menu twice. The crash should be fixed but until someone takes a closer look at what's going wrong this is an avenue for you to explore.

[Headline]

@leoTiGRiS any updates on this?

[asherkin]

This crash is quite common, the cause is if a menu handle is deleted while it is open for any clients. This doesn't affect most plugins as they use temporary menu handles and delete them in the MenuAction_End callback when SM guarantees it is safe.

We have all sorts of logic for keeping handle clones around in the internal menu objects and generally keeping track of state already, so this is probably just something that isn't wired up correctly. I suspect we should be able to cancel the menu in the OnHandleDestroy callback and call it a day, but it needs a reproduction written and testing.