alliedmodders / sourcemod

SourceMod - Source Engine Scripting and Administration
http://www.sourcemod.net/
965 stars 421 forks source link

Sourcemod loader doesn't load sourcemod.[engine].so from +sm_basepath #1160

Open bottiger1 opened 4 years ago

bottiger1 commented 4 years ago

It seems like the sourcemod loader doesn't take into account +sm_basepath when loading sourcemod.[engine].so. It just loads the file from addons/sourcemod no matter what sm_basepath is.

How to reproduce:

1) install sourcemod in the regular directory of addons/sourcemod. 2) copy addons/sourcemod to addons/sourcemod_test 3) symlink addons/sourcemod_test/bin to a custom build of sourcemod (ie: sourcemod/build/package/addons/sourcemod/bin) with a logging message in a "core" cpp file (ie. core/PlayerManager.cpp) and a "logic" cpp file (ie. core/logic/smn_players.cpp) 4) start the server with +sm_basepath addons/sourcemod_test and notice that your "logic" changes work, but "core" changes don't. 5) delete addons/sourcemod/bin, restart the server, and notice that sourcemod fails to load.

This probably doesn't affect most people since most people won't be using sm_basepath and compiling a custom version of sourcemod into a different basepath. But I was very confused why half my changes to sourcemod weren't working and it took a while to figure out. If it isn't fixed maybe a note should be provided as a warning.

CrazyHackGUT commented 4 years ago

CS:GO? https://github.com/alliedmodders/hl2sdk/pull/61