alliedmodders / sourcemod

SourceMod - Source Engine Scripting and Administration
http://www.sourcemod.net/
986 stars 423 forks source link

Issues from the recent builds [spcomp.exe especially, CS:GO Sv. OnClientPutInServer crash] #1286

Closed ClaudiuHKS closed 4 years ago

ClaudiuHKS commented 4 years ago

Help us help you

Environment

Description

Guys, since spcomp.exe is 464 Kb (Build # 6545 is 453 Kb), characters form .sp that are looking like ăîâșțĂÎÂȘȚ don't show correctly with UTF-8 encoding (didn't try UTF-8-BOM .sp encoding yet and also don't wanna try). Just saying. Also, with Build # 6562, the game server crashes when the client puts in server on Windows. Wasn't able to test Build # 6563 and 6565 because lack of Windows release to be downloaded from the Dev. branches.

Tested with CS:GO game [730 cl 740 sv Steam(tm) AppID].

I note that I actually run Build # 6559 and works perfectly on my public community dedicated CS:GO game server.

I note that I actually run compile.exe & spcomp.exe from the Build # 6545.

dvander commented 4 years ago

Can you attach a test script and describe how to reproduce the problem?

ClaudiuHKS commented 4 years ago

testscript.zip

This is for the spcomp.exe issue. About the OnClientPutInServer crash I have no idea yet, I will come back with a message soon. I mean, I have no idea if it crashes with a specific plug-in or it crashes even without any plug-in at all too.

The characters printed in chat are looking like ?????@...,,@E@FF@. Only when compiled with spcomp.exe having 464 Kb (Windows). Didn't try on Linux. When compiled with spcomp.exe having 453 Kb, it works fine.

ClaudiuHKS commented 4 years ago

I am back.

Build # 6559 /csgo/addons/sourcemod/bin/ OK & /csgo/addons/sourcemod/extensions/ OK Build # 6562 /csgo/addons/sourcemod/bin/ FAIL & /csgo/addons/sourcemod/extensions/ OK

This is how to reproduce a crash after OnClientPutInServer is called, with a PrintToChatAll call: hattricks_connect_announcer.zip

Note, I use bot_quota 6 & bot_join_after_player 0 in my testing game server. These two values are not the default values for these ConVars. Just saying.

I note that I have no idea if there are any other calls causing crashes. I have just found this one for now.

LogMessage("Step 1"); is logged but LogMessage("Step 2"); is never logged.

dvander commented 4 years ago

Thanks, I'll test this today.

dvander commented 4 years ago

The utf8 issue should be fixed. I'll test the crash as soon as I can.