ConVar.IntValue returns the wrong value

[ecsr]

Help us help you

• [x] I have checked that my issue doesn't exist yet.
• [x] I have tried my absolute best to reduce the problem-space and have provided the absolute smallest test-case possible.
• [x] I can always reproduce the issue with the provided description below.

Environment

• Operating System version: Linux and Windows
• Game/AppID (with version if applicable): Counter-Strike Source
• Current SourceMod version: 1.11.6906
• Current SourceMod snapshot: 1.11.6906
• Current Metamod: Source snapshot: 1.11.1148
• [x] I have updated SourceMod to the latest version and it still happens.
• [x] I have updated SourceMod to the latest snapshot and it still happens.
• [x] I have updated SourceMM to the latest snapshot and it still happens.

Description

ConVar.IntValue returns the wrong value for larger odd numbers. I'm only able to reproduce this on Linux; on Windows everything is working as expected. There is an old issue (#648) from 2017 that reported the same problem but for CS:GO.

Problematic Code (or Steps to Reproduce)

public void OnPluginStart()
{
    ConVar convar = CreateConVar("test_intvalue", "35781985");
    PrintToServer("IntValue: %d", convar.IntValue);
}

Logs

game output:

sm plugins load test-intvalue.smx
IntValue: 35781984
[SM] Loaded plugin test-intvalue.smx successfully.

[einyux]

Looks like an issue from Valve.

https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/sp/src/tier1/convar.cpp#L784

The value is converted from string to float, then float to int. The issue is that "35781985" is not exactly representable in floating-point (See https://www.h-schmidt.net/FloatConverter/IEEE754.html), so "35781985" is converted to 35781984.0, then 35781984.

=> Solution: Ask Valve to convert the string to int directly :D