alliedmodders / sourcemod

SourceMod - Source Engine Scripting and Administration

http://www.sourcemod.net/

972 stars 420 forks source link

Stock adminhelp.smx has issues. #1808

Open RicochetYT opened 2 years ago

RicochetYT commented 2 years ago

Help us help you

[x] I have checked that my issue doesn't exist yet.
[x] I have tried my absolute best to reduce the problem-space and have provided the absolute smallest test-case possible.
[x] I can always reproduce the issue with the provided description below.

Environment

Operating System version: Arch Linux [x86_64]
Game/AppID (with version if applicable): 440
Current SourceMod version: 1.11.0.6906
Current SourceMod snapshot: 1.12.0.6910
Current Metamod: Source snapshot: 1.12.0-dev+1160
[x] I have updated SourceMod to the latest version and it still happens.
[x] I have updated SourceMod to the latest snapshot and it still happens.
[x] I have updated SourceMM to the latest snapshot and it still happens.

Description

sm_help displays an invalid number of pages/entries on dedicated server There are no errors in the server console.

Problematic Code (or Steps to Reproduce)

Install latest version of Sourcemod and Metamod, change nothing.
Type sm_help 9999 in console
Receive page 9999 despite there not being that many entries.

Logs

N/A

RicochetYT commented 2 years ago

And yes, this happens after I did a complete reinstall of the TF2 dedicated server, Sourcemod, and Metamod, completely stock.

Impact123 commented 2 years ago

I can reproduce this. It has been introduced with #1388. The behavior of ReadCommandIterator() and CommandIterator.Next() is different.