Synergy player reconnecting causing server crash

[yarik2720]

Help us help you

• [x] I have checked that my issue doesn't exist yet.
• [x] I have tried my absolute best to reduce the problem-space and have provided the absolute smallest test-case possible.
• [x] I can always reproduce the issue with the provided description below.

Environment

• Operating System version: Ubuntu 14.04.5 LTS
• Game/AppID (with version if applicable): Synergy (public branch) / 17520
• Current SourceMod version: 1.10.0.6373
• Current SourceMod snapshot: 6373:1b3599c
• Current Metamod: Source snapshot: 966:5374982
• [x] I have updated SourceMod to the latest version and it still happens.
• [x] I have updated SourceMod to the latest snapshot and it still happens.
• [x] I have updated SourceMM to the latest snapshot and it still happens.

Description

Server crashes when player reconnecting, no matter if it is disconnect by user or client time out

Problematic Code (or Steps to Reproduce)

Player disconnect and reconnecting on the same map

Logs

• https://crash.limetech.org/stats/e81428511f6b79cf58239f16e1004b4b2a23cc2dfb07f156a743727cfaee996c5577a78691cf7059
• https://crash.limetech.org/mmyzrdql7ahb
• https://crash.limetech.org/rm23csqyqhcp

[Balimbanana]

This appears to be a Synergy problem to do with level transitions attempting to restore the player edict and load data from previous levels. A way to reproduce it is by going to d2_coast_07, proceed to 08, enable trigger_coop and trigger_changelevel, walk back to 07. If the server doesn't crash on load already, running retry in console will crash the server upon OnClientPutInServer attempting to load player data from multiple sources. It can also happen on random regular maps as well, not just in this situation. But this is one that I can reproduce at least 90% of the time.

I have written a plugin in SourceMod called SynSaveRestore which disables Synergy's transition data and rebuilds the relevant data in SourceMod to be loaded on transition on the next map. This appears to have solved the reconnect crash bug. Now there are just a few things to iron out for what should/shouldn't transition, but mainly, it is stable.