allista / ThrottleControlledAvionics

A mod for KerbalSaceProgram
Other
52 stars 22 forks source link

RCS module handling needs to account for disabled `thrusterTransforms` #111

Open gotmachine opened 2 years ago

gotmachine commented 2 years ago

Note that I haven't looked at your code or tested how TCA handle RCS modules. But FYI, since the introduction of the stock mesh-switchable RCS parts with variable nozzle configurations, it is now necessary to verify that a Transform entry in ModuleRCS.thrusterTransforms is actually enabled by checking transform.gameObject.activeInHierarchy.

allista commented 2 years ago

Thank you for reporting this one. I wonder if the engines need the same treatment?

gotmachine commented 2 years ago

From a quick look I don't see a similar check in ModuleEngines, so I guess not.