allo- / ffprofile

A tool to create firefox profiles with personalized defaults.
GNU Affero General Public License v3.0
771 stars 56 forks source link

Undefined name: files --> files_inline #146

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

files is an undefined name in this context which has the potential to raise NameError at runtime. This PR proposes to use __files_inline__ instead.

flake8 testing of https://github.com/allo-/firefox-profilemaker on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./forms.py:67:25: F821 undefined name 'files'
                        files.update(option['files_inline'][choice])
                        ^
1     F821 undefined name 'files'
1
allo- commented 5 years ago

Thank you.