allo- / ffprofile

A tool to create firefox profiles with personalized defaults.
GNU Affero General Public License v3.0
769 stars 56 forks source link

uMatrix installs itself even if I haven't checked the box to do so #233

Closed ghost closed 1 year ago

ghost commented 2 years ago

i just made a new profile to get rid of this persisting garbage of an extension and to my surprise, it reinstalled itself, though I have deleted everything on my profile folder + I haven't checked it on the ffprofile website

allo- commented 2 years ago

I can reproduce the bug when using enterprise policies.

Other addons pull in unselected addons as well. For example only selecting Cookie Autodelete creates the policy:

{
  "policies": {
    "ExtensionSettings": {
      "CookieAutoDelete@kennydo.com": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/cookie-autodelete/latest.xpi",
        "installation_mode": "normal_installed"
      },
      "uBlock0@raymondhill.net": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi",
        "installation_mode": "normal_installed"
      },
      "jid1-MnnxcxisBPnSXQ@jetpack": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/privacy-badger17/latest.xpi",
        "installation_mode": "normal_installed"
      },
      "https-everywhere@eff.org": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/https-everywhere/latest.xpi",
        "installation_mode": "normal_installed"
      },
      "CanvasBlocker@kkapsner.net": {
        "install_url": "https://addons.mozilla.org/firefox/downloads/latest/canvasblocker/latest.xpi",
        "installation_mode": "normal_installed"
      }
    }
  }
}

I think we had another bug with enterprise policies, which is still unresolved #220. I had disabled the enterprise policy download button as workaround on the production site, but it got activated after some update again.

allo- commented 2 years ago

Regarding the reinstallation: Enterprise-Policies only allow you to disable an extension, but not to uninstall ist.

ghost commented 2 years ago

So I should just disable the extension instead of uninstalling it? Alright, thanks Also, should I leave this issue open?

allo- commented 2 years ago

Leave it open. It is a bug that the option selects other options as well.

I only need more time to find the actual bug. The other linked bug contains some debugging information, if you like to have a look into it.

allo- commented 1 year ago

@km-ch I believe this may be fixed by the latest commit. Can you test again?

allo- commented 1 year ago

Closed by #272.