search

allo- / ffprofile

A tool to create firefox profiles with personalized defaults.
GNU Affero General Public License v3.0
785 stars 56 forks source link

Add Firefox Suggest #234

Closed pistasjis closed 3 years ago

pistasjis commented 3 years ago

This PR attempts to add the ability to enable/disable Firefox Suggest. Firefox Suggest was introduced in Firefox 92 and is a very controversial addition to Firefox, and something I instantly noticed wasn't in this when I was going to use it for a firefox profile. I added that in this PR, all should be fine.

allo- commented 3 years ago

Are you sure, that disabling grouplabels is necessary / useful? When disabling quicksuggest in the settings dialog, I still get the "Firefox Suggest" label between "Visit page" and suggestions from bookmarks/history. This may be useful for some people.

I merge for now, but I am not sure if the additional cosmetic change is necessary or just something that all pages that discuss the feature are copy&pasting from each other.

pistasjis commented 3 years ago

I'm not sure either, I just disabled the label because I guess some just see it and instantly think it's tracking them, even though you need to have contextual suggestions enabled.