add pdf_js - Githubissues

allo- / ffprofile

A tool to create firefox profiles with personalized defaults.

GNU Affero General Public License v3.0

784 stars 56 forks source link

add pdf_js #236

Closed dimon4ezzz closed 3 years ago

dimon4ezzz commented 3 years ago

From this stackoverflow answer disabling is not very important, because:

that's not any different from any web page or framed web advertisement you browse to all day. It doesn't seem to be a problem in practice given equally "vulnerable" PDF viewers in Chrome, Edge, and Opera. You can always just close the tab as you would with a bad web page

see #224

allo- commented 3 years ago

This looks good. I'd like to ask you to change ...

The commit message to something like Disable Javascript in the PDF viewer (closes #224) or a similar descriptive message
I think that the description is overly specific especially without the link. Maybe you can just use the one suggested in #224?

dimon4ezzz commented 3 years ago

Thanks for the note! I have changed description and commit message.