allo-protocol / allo-v2

Core Allo V2 Contracts
GNU Affero General Public License v3.0
90 stars 73 forks source link

feat: qv impact stream refactor #645

Closed 0xOneTony closed 3 months ago

0xOneTony commented 3 months ago

QVImpactStream strategy refactor leveraging the new strategies and tools.

ilpepepig commented 3 months ago

The implementation looks good, but the strategy idea looks weird to me. Why would anyone use QVImpactStream instead of QVSimple which automatically calculates the payouts? Is there any reason the pool manager would deviate from the QV calculated payouts?

thelostone-mc commented 3 months ago

Why would anyone use QVImpactStream instead of QVSimple which automatically calculates the payouts

TLDR: it was a customer request when we built out the strategy for https://www.impact.stream/ No technical reasoning for doing this