search

allo-protocol / docs

v2 Documentation
https://docs.allo.gitcoin.co
MIT License
3 stars 3 forks source link

Strategy Overview Page V1 #46

Closed gabewin closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 0:06am
0xZakk commented 1 year ago

@gabewin - Overall, this looks good!

Can you format any function names, strategy names, etc as inline code blocks? Also, I think when we're talking about a strategy in the library, we should use the contract name (i.e. DonationVotingStrategy.sol)

Separately - @nfrgosselin, I think we should remove Strategy from the names of all the strategies

gabewin commented 1 year ago

Thanks Zakk! That should be handled by the new commit. Let me know if there's anything else.

@gabewin - Overall, this looks good!

Can you format any function names, strategy names, etc as inline code blocks? Also, I think when we're talking about a strategy in the library, we should use the contract name (i.e. DonationVotingStrategy.sol)

Separately - @nfrgosselin, I think we should remove Strategy from the names of all the strategies