search

alloc8or / gta5-nativedb-data

A database of all GTAV script commands ("natives"). Strictly for educational purposes! https://alloc8or.re/gta5/nativedb/
184 stars 98 forks source link

Research 0xE67C6DFD386EA5E7 #177

Closed Kekeke1337 closed 2 years ago

Kekeke1337 commented 2 years ago

I have researched the functionality that displays a text saying cash/bank before your balance, when you start playing GTA Online for the first time, in order to figure out which one is which. For context, this is what I mean; https://i.imgur.com/MiYUtNl.png

This native is extremely simple, it just sets certain bool. The code that handles the money balance HUD in the check for whether to use the functionality mentioned above

Kekeke1337 commented 2 years ago

I am not sure why 6 commits are amended here, but the changes are what I intend for, so it's fine I suppose?

alloc8or commented 2 years ago

I've actually tried to find a name for this one several times over the years and found ALLOW_CASH_WHILE_SCALEFORM_PAINT a while ago but still not sure whether that's a collision or not.

Kekeke1337 commented 2 years ago

My guess is that it's just a very good collision. Like it describes it perfectly and has the same hash, but the name is far from anything else R* has used, so I doubt it. I think we're better off with a name like mine until someone finds the real one.

gottfriedleibniz commented 2 years ago

Is the joaat for this native correctly mapped from console? Asking because it is close to the *_FAKE_MP_CASH natives that were recently updated (0x6253B9D7 and 0xE319F90B).

One potential collision: 0x5476b9fd = DISPLAY_CASH_AND_DRAW_PARENT

Kekeke1337 commented 2 years ago

No idea tbh. If you want to look it up yourself, it's pretty easy to find. Look for the MENU_PLYR_CASH or MENU_PLYR_BANK text labels. You'll see an if statement that checks certain bool before concatenating.

Kekeke1337 commented 2 years ago

Hey. Is there any reason that this pull request is yet to be merged (or closed)? Is it perhaps the fact that somehow I pushed all commits? If so, I've tried squashing them, but the Github app wouldn't let me, since I have this pull request open. Should I close this and make a new one?

alloc8or commented 2 years ago

Will probably merge this later today.