search

alloc8or / gta5-nativedb-data

A database of all GTAV script commands ("natives"). Strictly for educational purposes! https://alloc8or.re/gta5/nativedb/
184 stars 98 forks source link

Fix duplicate "entity" parameters in WAYPOINT_PLAYBACK_START_SHOOTING_AT_PED #211

Closed WithLithum closed 1 year ago

WithLithum commented 1 year ago

The commit simply renames two entity parameters in WAYPOINT_PLAYBACK_START_SHOOTING_AT_PED to entity1 and entity2.

alloc8or commented 1 year ago

Looks like #205 changed these params to Ped ped. Still duplicates though...

slavexe commented 1 year ago

I'm pretty sure the second parameter should be renamed to Ped target as that makes logical sense based off how R* uses this native in the scripts. That way it would match what I did in #205 for the second parameter of TASK::WAYPOINT_PLAYBACK_START_AIMING_AT_PED.

kagikn commented 1 year ago

208 changes the signature to void WAYPOINT_PLAYBACK_START_SHOOTING_AT_PED(Ped iPed, Ped iTargetPed, BOOL bRunAndGun, BOOL FiringPatternHash) as the leak says expect the 4th parameter type in #208 is wrong (should be Hash).

alloc8or commented 1 year ago

Merged #214 for now, as I just want it fixed atm and can't be bothered to resolve the conflicts.