search

alloc8or / gta5-nativedb-data

A database of all GTAV script commands ("natives"). Strictly for educational purposes! https://alloc8or.re/gta5/nativedb/
177 stars 98 forks source link

Rename GET_FILENAME_FOR_AUDIO_CONVERSATION to GET_LABEL_LOCALIZED_TEXT #233

Closed ericr98 closed 1 year ago

ericr98 commented 1 year ago

The native GET_FILENAME_FOR_AUDIO_CONVERSATION was renamed in the "418 I'm a teapot" commit, but is now very confusing to associate with what it really does. It (maybe also, but it is what I have used it for) outputs a localized text version of a given label (for e.g. clothes, or vehicle mods).

I therefore propose to rename it, or if that is not wished at least specify in the comment what it is doing.

alloc8or commented 1 year ago

GET_FILENAME_FOR_AUDIO_CONVERSATION is the real name. However, I agree that the comment could be better.