This PR fixes a critical-severity issue that would allow any random person on the internet to denial of service the Allora chain, by sending a negative Coin amount to the RemoveDelegateStake function. The fix merely checks that the value is positive, thereby preventing an eventual panic and halt of the chain.
Testing and Verifying
This change added tests that check that you cannot try to RemoveStake of negative amounts of coins.
relyt29
commented
1 month ago
What is the purpose of the change
This PR fixes a critical-severity issue that would allow any random person on the internet to denial of service the Allora chain, by sending a negative Coin amount to the RemoveDelegateStake function. The fix merely checks that the value is positive, thereby preventing an eventual panic and halt of the chain.
Testing and Verifying
This change added tests that check that you cannot try to RemoveStake of negative amounts of coins.
Documentation and Release Note
This PR has no implications on documentation.