search

allora-network / allora-chain

Node software to run the Allora Network
https://www.allora.network/
Apache License 2.0
76 stars 71 forks source link

Validate all Values for Correctness Prior to Storing them in the Keeper #603

Open relyt29 opened 5 days ago

relyt29 commented 5 days ago

Purpose of Changes and their Description

In order to aid in ensuring correct state, and to practice defense-in-depth, we should check all values for correctness at the final step, right before the values are written into the keeper.

Link(s) to Ticket(s) or Issue(s) resolved by this PR

PROTO-2341, all of the NaN work in release v0.5.0

Are these changes tested and documented?

This PR does not change any user or external facing code, so no documentation updates are needed.

PR added to the Unreleased section of CHANGELOG.md

Still Left Todo

A massive amount of tests need to be fixed. Will probably keep the tests on a separate branch so that the PR can be reviewed separate from the tests.

relyt29 commented 1 day ago

The tests for this PR are going in #608