allora-network / allora-chain

Node software to run the Allora Network
https://www.allora.network/
Apache License 2.0
78 stars 72 forks source link

Non-deferred close checker #620

Closed spooktheducks closed 1 month ago

spooktheducks commented 1 month ago

Run this on CI. Catches non-deferred .Close() calls, understands deferred func literals containing simple .Close() calls as well as simple defer statements

relyt29 commented 1 month ago

This is great, few things:

  1. Nothing exists in golang-ci for this very case? I'd prefer to push the work of maintaining such a script to golang-ci people
  2. This code is great but doesn't actually add it to our CI, shouldn't we do that in this PR here
kpeluso commented 1 month ago

Should add to makefile as well

github-actions[bot] commented 1 month ago

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedOct 5, 2024, 12:29 AM