Diego/proto 2657 add mint event on reward emission

allora-network / allora-chain

Node software to run the Allora Network

https://www.allora.network/

Apache License 2.0

78 stars 72 forks source link

Diego/proto 2657 add mint event on reward emission #632

Closed xmariachi closed 2 weeks ago

xmariachi commented 2 weeks ago

Purpose of Changes and their Description

Add event on mint module
added v3 event protos
updated and added tests

Link(s) to Ticket(s) or Issue(s) resolved by this PR

Are these changes tested and documented?

[X] If tested, please describe how. If not, why tests are not needed. -- updated unit tests, also launched a chain and tested with RPC block_results.
[X] If documented, please describe where. If not, describe why docs are not needed. -- part of major pr, no need
[X] Added to Unreleased section of CHANGELOG.md? -- part of major pr, no need

Still Left Todo

Fill this out if this is a Draft PR so others can help.

github-actions[bot] commented 2 weeks ago

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`⏩ skipped`	Oct 18, 2024, 5:59 PM

relyt29 commented 2 weeks ago

can you also emit the amount sent to the cosmos validators separately from the allora rewards, so that PROTO-2257 is covered, since you're already doing this

xmariachi commented 2 weeks ago

can you also emit the amount sent to the cosmos validators separately from the allora rewards, so that PROTO-2257 is covered, since you're already doing this

Not clear what do you mean exactly but feel free to add it to the branch if easy. Anyway probs we should stop adding stuff to this pr if unrelated and do that separately

xmariachi commented 2 weeks ago

golangci-lint run is passing for me locally, it's failing due to timeout though