fix nil pointer bug in GetNetworkInferences - Githubissues

allora-network / allora-chain

Node software to run the Allora Network

https://www.allora.network/

Apache License 2.0

78 stars 72 forks source link

fix nil pointer bug in GetNetworkInferences #635

Closed spooktheducks closed 2 weeks ago

spooktheducks commented 2 weeks ago

Purpose of Changes and their Description

There was an occasional nil pointer panic in GetNetworkInferences

Link(s) to Ticket(s) or Issue(s) resolved by this PR

https://linear.app/alloralabs/issue/PROTO-2728/fix-nil-pointer-dereference-panic-in-getnetworkinferences

Are these changes tested and documented?

[x] If tested, please describe how. If not, why tests are not needed.
- Ran the test suite
[x] If documented, please describe where. If not, describe why docs are not needed.
- New test cases added for both specific block and latest block. Confirmed nil pointer bug before implementing fix.
[x] Added to Unreleased section of CHANGELOG.md?

Still Left Todo

🔴 🔴 🔴 There are several places marked TODO(spook) that I need some feedback from the team on. 🔴 🔴 🔴

github-actions[bot] commented 2 weeks ago

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`⏩ skipped`	Oct 22, 2024, 6:39 PM