search

alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project
https://alloy.rs
Apache License 2.0
644 stars 231 forks source link

Support for using some crates with SP1 #1112

Closed manav2401 closed 1 week ago

manav2401 commented 3 months ago

Component

other

Describe the feature you would like

I want to use alloy-primitives and alloy-rlp as a dependency in SP1 but it doesn't compile. It'll be great if this command worked for these 2 crates.

Thanks!

Additional context

No response

DaniPopes commented 3 months ago

Can you please elaborate on "it doesn't compile"? All of the crates in that script depend on either alloy-primitives, alloy-rlp, or both, so by default these also compile using that command.

manav2401 commented 3 months ago

All of the crates in that script depend on either alloy-primitives, alloy-rlp, or both, so by default these also compile using that command.

Ahh didn't know that, thanks!

Can you please elaborate on "it doesn't compile"?

Sure. Basically I added reth-primitives, alloy-primitives and alloy-rlp as a dependency in my SP1 project. While the root rust program compiles well, SP1's zkVM can't really compile the programme for generating proofs. I had a discussion with their team and they mentioned that they maintain a custom fork for such compatibility changes. I thought it will be great to have those custom changes (which I am not fully aware of) in the main repo itself. They mentioned that they'll create these PRs and they'll also update the CI such that any changes which affects their lifecycle gets caught.

TL;DR: This might be something which their team will take a look into. Thanks!