search

alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project
https://alloy.rs
Apache License 2.0
664 stars 239 forks source link

fix: sidecar rlp decoding #1549

Closed klkvr closed 1 month ago

klkvr commented 1 month ago

Motivation

Right now this encodes as list and expects string during decoding which is incorrect.

I am wondering if we should remove those impls completely? Given that sidecar encoding on its own is not defined

Solution

PR Checklist

prestwich commented 1 month ago

yep this is a logic bug in #1528 😅

I am wondering if we should remove those impls completely? Given that sidecar encoding on its own is not defined

sidecar encoding on its own is defined, because RLP is well-defined for any set of RLP objects. It is not used anywhere that we're aware of https://github.com/alloy-rs/alloy/pull/1528#issuecomment-2424298961