search

alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project
https://alloy.rs
Apache License 2.0
664 stars 239 forks source link

chore(general): bump MSRV to 1.81, use `core::error::Error` on `no-std` compatible crates #1552

Open Evalir opened 1 month ago

Evalir commented 1 month ago

Motivation

For no-std compatible crates, we can use core::error::Error instead of std::error::Error to avoid gating the Error impl under std for the impl blocks.

Solution

replace std::error::Error with core::error::Error on the impl blocks.

PR Checklist

DaniPopes commented 1 month ago

I'm ok with bumping MSRV for this since it's in line with our policy. Do you want to do this in alloy-core too?

Evalir commented 1 month ago

Yep, happy to do it on alloy core too. Sounds good!

Evalir commented 1 month ago

@DaniPopes i've not removed any std error feature gates where we reuse errors from alloy-rlp/const-hex/ruint. should we bump there too, or is leaving it like it OK for now?

Core PR: https://github.com/alloy-rs/core/pull/780

zerosnacks commented 1 week ago

Added a temporary blocked label as it relies on 1.83 being released: https://releases.rs/docs/1.83.0/