search

alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project
https://alloy.rs
Apache License 2.0
664 stars 239 forks source link

eips: add missing unit test for `MIN_PROTOCOL_BASE_FEE` #1558

Closed tcoratger closed 1 month ago

tcoratger commented 1 month ago

As in reth we will eliminate unnecessary redeclarations here (to import alloy constants):

https://github.com/paradigmxyz/reth/blob/5e4da59b3a83c869647ad38b6f679f7594c11938/crates/primitives-traits/src/constants/mod.rs#L12-L24

We also need to make sure that the reth test:

https://github.com/paradigmxyz/reth/blob/5e4da59b3a83c869647ad38b6f679f7594c11938/crates/primitives-traits/src/constants/mod.rs#L83-L91

is in alloy in order to secure the implementation.