Serialization traits for Transaction struct

alloy-rs / alloy

Transports, Middleware, and Networks for the Alloy project

https://alloy.rs

Apache License 2.0

664 stars 239 forks source link

Serialization traits for Transaction struct #1571

Closed nadtech-hub closed 3 weeks ago

nadtech-hub commented 1 month ago

Motivation

It brings implementation of Serialize, Deserialize traits for Transaction struct. It should close 1409

PR Checklist

[x] Added Tests
[ ] Added Documentation
[ ] Breaking changes

nadtech-hub commented 3 weeks ago

I read EIPs of all tx types while implementing serialization. I guess it may need refactoring after merging envelope implementation you refered. I would make Signature's v param optional since it is only seen in tx type 0 (legacy), tx type 1 and higher doesn't feature it

klkvr commented 3 weeks ago

hmm, wouldn't this become a non issue with #1460 @klkvr ?

yep, I think it would

nadtech-hub commented 3 weeks ago

I incline to agree with your point

nadtech-hub commented 3 weeks ago

So I close this one?

mattsse commented 3 weeks ago

yeah, sorry about this